Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ship-shape: Does not check whether css/js aggregation and caching is turned on #31

Open
klonos opened this issue Nov 25, 2021 · 0 comments
Open

ship-shape: Does not check whether css/js aggregation and caching is turned on #31

klonos opened this issue Nov 25, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@klonos
Copy link
Contributor

klonos commented Nov 25, 2021 •
edited
Loading

I just run ahoy ship-shape for a forklift, and I got no failures. Manual checking after the forklift showed that css/js aggregation and caching is turned off:

image

Drutiny used to check and warn for these things, so we also need to be checking them with ship-shape for parity.
@klonos klonos added the bug Something isn't working label Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@klonos