Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retry_on_http_429: false no effect when configured for static agent #7065

Open
Reimirno opened this issue Nov 18, 2024 · 1 comment
Open
Labels
bug Something isn't working needs-attention An issue or PR has been sitting around and needs attention.

Comments

@Reimirno
Copy link

What's wrong?

retry_on_http_429: false should suppress agent from retrying on code 429, but it does not.

Steps to reproduce

using this config for prometheus remote write

"remote_write":
    - "queue_config":
        "retry_on_http_429": false

agent will still retry when seeing 429.

It is probably because agent is using an old prometheus library whose queueconfig does not support that field yet.

System information

No response

Software version

v0.42.0

Configuration


Logs


@Reimirno Reimirno added the bug Something isn't working label Nov 18, 2024
Copy link
Contributor

This issue has not had any activity in the past 30 days, so the needs-attention label has been added to it.
If the opened issue is a bug, check to see if a newer release fixed your issue. If it is no longer relevant, please feel free to close this issue.
The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your issue will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity.
Thank you for your contributions!

@github-actions github-actions bot added the needs-attention An issue or PR has been sitting around and needs attention. label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-attention An issue or PR has been sitting around and needs attention.
Projects
None yet
Development

No branches or pull requests

1 participant