Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exec.vu.tags: Tags not overwritten consistently by System Tags #2221

Closed
mstoykov opened this issue Nov 3, 2021 · 1 comment
Closed

exec.vu.tags: Tags not overwritten consistently by System Tags #2221

mstoykov opened this issue Nov 3, 2021 · 1 comment
Assignees
Labels
evaluation needed proposal needs to be validated or tested before fully implementing it in k6 ux

Comments

@mstoykov
Copy link
Contributor

mstoykov commented Nov 3, 2021

Feature Description

after #2172 there will be a way for script code to add tags to be emitted for all metrics emitted by the vu, this, unfortunately, has some tags that it just won't work with such as :

Both of those as can be seen just overwrite the tag as long as it's enabled in system tags.

This isn't true for all tags, for example name actually gets checked (twice) and won't be overwritten.

I haven't checked anything else but I would expect there will be more of this :).

Suggested Solution (optional)

This is in practice the current behaviour for tags set in the Params AFAIK, so I guess it isn't really all that big of a problem.

Still, it might be good to it be known and to think about whether we want to change that.

@na-- na-- added evaluation needed proposal needs to be validated or tested before fully implementing it in k6 and removed question labels Nov 4, 2021
@codebien codebien changed the title set vu tags may not overwrite tags depending on what it overwrites exec.vu.tags: Tags not overwritten consistently by System Tags Nov 5, 2021
@codebien codebien self-assigned this Nov 5, 2021
@codebien
Copy link
Contributor

I checked all the system tags that we currently have and all of them are relying only on the Has method. The unique exception is name as reported in the description. I don't think we plan to change that logic around name so I'm closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
evaluation needed proposal needs to be validated or tested before fully implementing it in k6 ux
Projects
None yet
Development

No branches or pull requests

3 participants