Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back missing HTTP methods "connect", "trace" #443

Closed
robingustafsson opened this issue Jan 8, 2018 · 2 comments
Closed

Add back missing HTTP methods "connect", "trace" #443

robingustafsson opened this issue Jan 8, 2018 · 2 comments

Comments

@robingustafsson
Copy link
Member

They seem to have gone missing when we switched from Otto to goja JS VMs (in https://github.com/loadimpact/k6/tree/v0.13.0).

See last implementation here (in JS at that time): https://github.com/loadimpact/k6/blob/v0.12.2/js/lib/k6/http.js

@cstyan
Copy link
Contributor

cstyan commented Jan 17, 2018

OPTIONS in #451

we should find a way to properly test CONNECT and TRACE before adding them, see #464

@na-- na-- changed the title Add back missing HTTP methods "connect", "options", "trace" Add back missing HTTP methods "connect", "trace" Feb 14, 2019
@na--
Copy link
Member

na-- commented Jan 21, 2021

TRACE seems like a marginal HTTP method that doesn't deserve its own shortcut, people can just use the generic http.request('TRACE', ...) call for it.

CONNECT is a special method for HTTP proxies. Proxies are currently supported by k6, using the the semi-standardized HTTP_PROXY, HTTPS_PROXY and NO_PROXY environment variables (which we need to better document soon - grafana/k6-docs#74). And if that's not enough, more flexible support for proxies is tracked in another issue, #1045.

So, I think we can close this...

@na-- na-- closed this as completed Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants