Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix artifacts resolving as -plain #13743

Closed
codeconsole opened this issue Oct 11, 2024 · 15 comments
Closed

fix artifacts resolving as -plain #13743

codeconsole opened this issue Oct 11, 2024 · 15 comments
Assignees

Comments

@codeconsole
Copy link
Contributor

codeconsole commented Oct 11, 2024

Artifacts should not resolve as -plain unless a Spring boot version is also resolved. It is not proper convention to add -plain classifiers to artifacts.

This could result in unwanted dependency resolution when gradle module files are also distributed.

   136374  10-11-2024 20:07   BOOT-INF/lib/asset-pipeline-grails-4.5.1-plain.jar
   330271  10-10-2024 05:31   BOOT-INF/lib/gsp-6.2.2-plain.jar
    46996  10-10-2024 05:31   BOOT-INF/lib/sitemesh2-6.2.2-plain.jar
    58173  10-11-2024 20:07   BOOT-INF/lib/hibernate5-8.1.0-plain.jar
   144196  10-10-2024 05:33   BOOT-INF/lib/fields-5.1.0-plain.jar
@matrei
Copy link
Contributor

matrei commented Oct 29, 2024

grails/grails-gsp#525

@matrei matrei moved this from Todo to In Progress in Grails 6.2.2 Oct 29, 2024
@matrei matrei self-assigned this Oct 29, 2024
@matrei
Copy link
Contributor

matrei commented Oct 31, 2024

gpc/fields#377

@matrei
Copy link
Contributor

matrei commented Nov 1, 2024

@codeconsole
Copy link
Contributor Author

codeconsole commented Nov 1, 2024

@matrei can this logic be placed into grails-gradle-plugin instead so that it always is applied to plugins?

@matrei
Copy link
Contributor

matrei commented Nov 1, 2024

Yes, I was thinking we should do that starting at 7.0.x.

@codeconsole
Copy link
Contributor Author

codeconsole commented Nov 1, 2024

well, it's unwanted unexpected behavior that did not previously exist so probably should be corrected in 6.2.x and merged forward into 7.0.x

@matrei
Copy link
Contributor

matrei commented Nov 1, 2024

Oh, ok, in which version did it start occurring?

@matrei
Copy link
Contributor

matrei commented Nov 1, 2024

No matter, I'll add the change to grails-gradle-plugin 6.2.x instead 👍

@codeconsole
Copy link
Contributor Author

@matrei I think it actually started with 6

@codeconsole
Copy link
Contributor Author

codeconsole commented Nov 1, 2024

Looks like it has been happening with hibernate5 plugin since 2021-05-29 13:37
https://repo.maven.apache.org/maven2/org/grails/plugins/hibernate5/

and gsp starting with 5.0.0.RC1 (2021-07-20), but did NOT occur in < 5.0.0.M1 (2021-07-20)
https://repo.maven.apache.org/maven2/org/grails/plugins/gsp/

@matrei
Copy link
Contributor

matrei commented Nov 3, 2024

@codeconsole
Copy link
Contributor Author

@matrei regarding your reverts, how do you want to handle

/ disable main class
bootJar {
    mainClass.set('dummy.Application')
}
findMainClass.onlyIf { false }

remove after revert?

@matrei
Copy link
Contributor

matrei commented Nov 4, 2024

@codeconsole These can be removed again, as bootJar is disabled.

remove after revert?

Yes

@matrei
Copy link
Contributor

matrei commented Nov 5, 2024

Closed by grails/grails-gradle-plugin#347

@matrei matrei closed this as completed Nov 5, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Grails 6.2.2 Nov 5, 2024
@jamesfredley
Copy link
Contributor

Tickets that will remove -plain from released versions

grails/grails-gsp#546 - gsp & sitemesh2
gpc/fields#380
grails/gorm-hibernate5#932

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants