-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Including org.grails.grails-gsp should automatically configure gsp compilation for web apps. #234
Comments
With Grails 6.0.0 installed through SDKman, I see that snippet in
Using https://start.grails.org/ it also shows the required snippet. |
@matthijsbierman that snippet shouldn’t be necessary and the plugin should automatically configure that behavior |
@codeconsole I see what you mean. Agreed, it would be best if the plugin itself configures it. |
This is already in place at https://github.com/grails/grails-gradle-plugin/blob/6.1.x/src/main/groovy/org/grails/gradle/plugin/web/gsp/GroovyPagePlugin.groovy#L87 Could you please verify if it still works after removing it from the |
Sure, I will check |
I can confirm that the following is no longer needed:
I did notice one other thing. It seems like the source gsp pages are also included. Is this expected behavior?
Also, has the code block been removed from the results of |
I think the class responsible for generating the |
|
This configuration is now done by the grails-gradle-plugin. Related: grails/grails-gradle-plugin#234
This configuration is now done by the grails-gradle-plugin. Related: grails/grails-gradle-plugin#234
As of Grails 6.0.0, it is now required to add the following to an apps
build.gradle
This should be configured automatically by the plugin. Previous versions of grails did not require this and the mention of the required addition was not added to the release announcement or release notes for 6.0.0
The text was updated successfully, but these errors were encountered: