Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

supabase adapter doesn't work with supabase^2.43.1 #223

Open
thecoorum opened this issue May 16, 2024 · 9 comments
Open

supabase adapter doesn't work with supabase^2.43.1 #223

thecoorum opened this issue May 16, 2024 · 9 comments

Comments

@thecoorum
Copy link
Contributor

While trying to install the supabase storage adapter it fails with Could not resolve dependency: peer @supabase/supabase-js@"^1.0.0" from @grammyjs/[email protected]

@KnorpelSenf
Copy link
Member

We just need to update

"@supabase/supabase-js": "^1.0.0"
and make sure that the adapter still works after that. Do you feel like opening a pull request for this?

@thecoorum
Copy link
Contributor Author

Yeah, will do!

@thecoorum
Copy link
Contributor Author

@KnorpelSenf are there any additional checks except for lerna tests to verify that bumping the dev dependency actually works?

@KnorpelSenf
Copy link
Member

I think the best way is if you try your changes in your own bot project and check that everything works as expected for you. This manual testing in addition to passing unit tests and type checks is definitely good enough.

@thecoorum
Copy link
Contributor Author

I initially installed it with npm i --force (I know that it's not the best solution, the patch-package was not the way here as it's done after install) and the bot is working correctly with grammy/web on Vercel edge function

@thecoorum
Copy link
Contributor Author

Here is the PR to allow ^2 of supabase as peer dependency - #224

@wangel13
Copy link

wangel13 commented Aug 6, 2024

same error:

npm error Could not resolve dependency:
npm error peer @supabase/supabase-js@"^1.0.0" from @grammyjs/[email protected]
npm error node_modules/@grammyjs/storage-supabase
npm error   @grammyjs/storage-supabase@"^2.4.2" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.

@cakeinpanic
Copy link

Same issue :(

@KnorpelSenf
Copy link
Member

Can you update your deps and try again? This should've been fixed in #224 already, I don't know why this issue was left open. @Satont or @thecoorum do you know more?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants