You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jul 25, 2024. It is now read-only.
At the moment, the fields key in %GraphQL.Type.ObjectType{} and args key only take a map with atom keys. For example:
%GraphQL.Schema{
query: %GraphQL.Type.ObjectType{
name: "RootQueryType",
fields: %{
greeting: %{
type: %GraphQL.Type.String{},
args: %{
name: %{type: %GraphQL.Type.String{}, description: "The name of who you'd like to greet."}
},
resolve: fn(_,_,_) -> "Hello" end
}
}
}
}
However, there are cases where those fields are generated from user's input. By using atoms, we can run out of atoms in the Erlang shell, since atoms are not garbage collected.
It would be ideal to also support this:
%GraphQL.Schema{
query: %GraphQL.Type.ObjectType{
name: "RootQueryType",
fields: %{
"greeting" => %{
type: %GraphQL.Type.String{},
args: %{
"name" => %{type: %GraphQL.Type.String{}, description: "The name of who you'd like to greet."}
},
resolve: fn(_,_,_) -> "Hello" end
}
}
}
}
The text was updated successfully, but these errors were encountered:
sntran
changed the title
Support string field
Support string fields and args
Oct 3, 2016
I'm not trying to rush here, but I would like to hear the arguments against this. I can see that the dot notation when using atom is nicer than square brackets, but other than that, I see no harm in supporting both.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
At the moment, the
fields
key in%GraphQL.Type.ObjectType{}
andargs
key only take a map with atom keys. For example:However, there are cases where those fields are generated from user's input. By using atoms, we can run out of atoms in the Erlang shell, since atoms are not garbage collected.
It would be ideal to also support this:
The text was updated successfully, but these errors were encountered: