Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools/amplify-preview improvements #306

Open
taraspos opened this issue Dec 24, 2024 · 0 comments
Open

tools/amplify-preview improvements #306

taraspos opened this issue Dec 24, 2024 · 0 comments

Comments

@taraspos
Copy link
Contributor

Summary

Following improvements for amplift-preview can be implemented:

  1. Make retries-count configurable

    const (
    jobWaitSleepTime = 30 * time.Second
    jobWaitTimeAttempts = 40
    )

  2. Set relevant outputs to GITHUB_OUTPUT:

    • Preview App ID
    • Preview Branch Name
    • Preview Job ID

    Those values can be used then to compose copy-pastable command to fetch deployment logs (like aws amplify get-job --app-id <APP_ID> --branch-name <BRANCH_NAME> --job-id <JOB_ID> and printed in case of error:

@taraspos taraspos changed the title amplify-preview improvements tools/amplify-preview improvements Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant