feat: improve handling aria props #1958
Merged
+78
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanisAvko
requested review from
amje,
sofiushko,
Raubzeug,
SeqviriouM,
DakEnviy,
Lunory,
jhoncool,
Vladeeg,
NikitaCG,
goshander,
d3m1d0v,
v4dyar4,
ogonkov,
Marginy605,
IsaevAlexandr,
ValeraS and
korvin89
as code owners
|
Preview is ready. |
|
Visual Tests Report is ready. |
ValeraS
requested changes
Nov 21, 2024
| }: ActionsPanelProps) => { | ||
| return ( | ||
| <div className={b(null, className)} data-qa={qa}> | ||
| <div | ||
| {...filterDOMProps(otherProps, {labelable: true})} |
There was a problem hiding this comment.
Aria labelling attributes on element with implicit or explicit role none / presentation are redundant. Use appropriate role or remove them.
Please look through other similar places.
DanisAvko
force-pushed
the
feat/improve-handling-aria-props
branch
3 times, most recently
from
cb6c66b to
116afec
Compare
|
Yes, didnt notice it from mobile app |
amje
requested changes
Nov 26, 2024
src/components/Alert/Alert.tsx
Outdated
| style={style} | ||
| className={bAlert({corners}, spacing({py: 4, px: 5}, className))} | ||
| theme={theme} | ||
| view={view} | ||
| qa={qa} | ||
| role="alert" |
There was a problem hiding this comment.
Alert is used more like continer, not like aria alert, this prop and labelable props not needed here
DanisAvko
force-pushed
the
feat/improve-handling-aria-props
branch
2 times, most recently
from
cd2e988 to
b321baf
Compare
amje
approved these changes
Dec 3, 2024
ValeraS
approved these changes
Dec 4, 2024
DanisAvko
force-pushed
the
feat/improve-handling-aria-props
branch
3 times, most recently
from
58b5337 to
fecc997
Compare
DanisAvko
force-pushed
the
feat/improve-handling-aria-props
branch
from
fecc997 to
a64279f
Compare
amje
approved these changes
Dec 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.