Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Spindle At Speed Tolerance setting in Spindle settings group #646

Open
LoganFraser opened this issue Jan 2, 2025 · 1 comment

Comments

@LoganFraser
Copy link

The Spindle At Speed Tolerance (or more commonly disable) is moved from Spindle settings group to Door group when Door input is enabled. This creates confusion and difficulty finding the setting when the end user isn't aware of or using the Door input.

Recommendation - remove the relocation of Spindle At Speed Tolerance setting when Door input is enabled.

@terjeio
Copy link
Contributor

terjeio commented Jan 3, 2025

The Spindle At Speed Tolerance (or more commonly disable) is moved from Spindle settings group to Door group when Door input is enabled.

This must be in an older version because it is not so in the current version... The spindle on delay used for timeout before alarm 14 is moved though.
Anyway, the new settings struct has separate fields reserved for spindle spin up and coolant start - and I have just updated the code to make use of them. See the changelog for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants