diff --git a/groovy-eclipse.setup b/groovy-eclipse.setup index 891eb02df6..c712ce7890 100644 --- a/groovy-eclipse.setup +++ b/groovy-eclipse.setup @@ -305,13 +305,13 @@ + name="2024-12"> + url="https://download.eclipse.org/eclipse/updates/4.34-I-builds/I20241120-1800"/> diff --git a/jdt-patch/e434/Feature-org.codehaus.groovy.jdt.patch/feature.xml b/jdt-patch/e434/Feature-org.codehaus.groovy.jdt.patch/feature.xml index 1e60b8d6e8..0668f2e5b3 100644 --- a/jdt-patch/e434/Feature-org.codehaus.groovy.jdt.patch/feature.xml +++ b/jdt-patch/e434/Feature-org.codehaus.groovy.jdt.patch/feature.xml @@ -18,7 +18,7 @@ - + variableBinding.getName().equals(pn)) && + Arrays.stream(declaringMethod.getParameterNames()).anyMatch(variableBinding.getName()::equals) && declaringMethod.getDeclaringClass() instanceof ITypeBinding recordBinding && recordBinding.isRecord() && recordBinding.getJavaElement() instanceof IType recordType && diff --git a/jdt-patch/e434/org.eclipse.jdt.core/model/org/eclipse/jdt/internal/core/DeltaProcessor.java b/jdt-patch/e434/org.eclipse.jdt.core/model/org/eclipse/jdt/internal/core/DeltaProcessor.java index 8505d77d24..f62651f5ec 100644 --- a/jdt-patch/e434/org.eclipse.jdt.core/model/org/eclipse/jdt/internal/core/DeltaProcessor.java +++ b/jdt-patch/e434/org.eclipse.jdt.core/model/org/eclipse/jdt/internal/core/DeltaProcessor.java @@ -30,6 +30,7 @@ import java.util.Set; import org.eclipse.core.resources.*; import org.eclipse.core.runtime.CoreException; +import org.eclipse.core.runtime.ILog; import org.eclipse.core.runtime.IPath; import org.eclipse.core.runtime.IProgressMonitor; import org.eclipse.core.runtime.ISafeRunnable; @@ -2022,7 +2023,9 @@ public void resetProjectCaches() { */ public void registerJavaModelDelta(IJavaElementDelta delta) { if (JavaModelManager.isReadOnly()) { - throw new IllegalStateException("Its not allow to modify JavaModel during ReadOnly action. delta=" + delta); //$NON-NLS-1$ + ILog.get().warn("JavaModel change during read only operation", new IllegalStateException( //$NON-NLS-1$ + "JavaModel modified during 'read only' operation. Consider to report this warning to https://github.com/eclipse-jdt/eclipse.jdt.core/issues. delta=" //$NON-NLS-1$ + + delta)); } this.javaModelDeltas.add(delta); } diff --git a/pom.xml b/pom.xml index ffa065f27a..292d3b4ff7 100644 --- a/pom.xml +++ b/pom.xml @@ -108,7 +108,7 @@ milestone p2 - https://download.eclipse.org/eclipse/updates/4.34-I-builds/I20241113-1800 + https://download.eclipse.org/eclipse/updates/4.34-I-builds/I20241120-1800