Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An attribute (not nn.Param) for Equivalent Width and FWHM #64

Open
gully opened this issue Sep 12, 2023 · 0 comments
Open

An attribute (not nn.Param) for Equivalent Width and FWHM #64

gully opened this issue Sep 12, 2023 · 0 comments

Comments

@gully
Copy link
Owner

gully commented Sep 12, 2023

What we want

An attribute for Equivalent Width. It will have the same shape as lam_centers, amp, sigma, and gamma, but it will not be an nn.Parameter. Just a derived parameter.

How to compute it

Two options:

  1. Analytically
    This turns out to be impossible for Voigt profiles because the Lorenzian long tails integrate to infinity. However, we could simply provide a number of FWHMs out to which we integrate. This choice has the benefit of operating on a table of derived properties $\sigma$, $A$, $\gamma$.

  2. Numerically
    Simply torch.sum() the n_lines axis of flux2D, including the size of the pixels in angstroms. Probably np.trapz or equivalent would work better (or scipy quad).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant