Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notes from reading the Overleaf #75

Open
5 tasks
gully opened this issue May 22, 2024 · 0 comments
Open
5 tasks

Notes from reading the Overleaf #75

gully opened this issue May 22, 2024 · 0 comments

Comments

@gully
Copy link
Owner

gully commented May 22, 2024

  • State more numbers-- the number of grid points you looked at. The number of unique Teff grid points, unique logg grid points, etc.
  • We repeated refer to the subset of the PHOENIX model grid the "PHOENIX subset". This almost seems like overly honest methods, since we could simply call it the "model grid" which is more familiar to most folks. I don't have a strong feeling here, just noticed reading that phrase a lot.
  • We should cite the Yuan-Sen Ting work on spectral inference if we don't already
  • Why does the stored interpolator take up so much more space (13 GB) than the pretrained models themselves(0.5 GB)? What is the intuition here for the factor of >20?
  • What ever happend to the phrase "bi-directional mapping"?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant