Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PWA App icon with rounded border #1

Open
kytosai opened this issue Nov 21, 2024 · 5 comments
Open

Update PWA App icon with rounded border #1

kytosai opened this issue Nov 21, 2024 · 5 comments
Assignees

Comments

@kytosai
Copy link

kytosai commented Nov 21, 2024

Hi,

Thank you very much for creating this chrome extension, it is very useful for me, however I am using MacOS and most of the icons on my Dock are rounded but the Slack PWA App icon is square, so I hope you add rounded icons

This will make the Slack PWA App icon look better on both Windows and MacOS

Thank you!

@gxanshu
Copy link
Owner

gxanshu commented Nov 21, 2024

@kytosai thanks for trying this extension. will update this weekend :)

@gxanshu gxanshu self-assigned this Nov 21, 2024
@kytosai
Copy link
Author

kytosai commented Nov 21, 2024

Sorry for the lack of additional screenshots, here's a screenshot of my current dock icon list, the Slack PWA App lacks roundness so it looks inconsistent ^^

image

@jlsrvr
Copy link

jlsrvr commented Dec 3, 2024

Hey @gxanshu,

wanted to also say thanks for the PWA, had the same comment as kytosai! I gave it a shot today to offer a solution but after following this creating all the correct icons and getting ready to propose a PR, I've come to the conclusion that you may not be able to do much about this.

I have a feeling that the icons we see are those defined by slack themselves.

How did I get to that conclusion -> before the PR tested my changes locally, they didn't seem to work, to make sure my icons were being taken into account I put some other random images. This is when I realised that the icon wasn't using the icons defined in the manifest and present in the asset file. Here is my work if needed

Any ways interested to see if you find a way around this.

@gxanshu
Copy link
Owner

gxanshu commented Dec 4, 2024

@jlsrvr thanks for info. i was a little busy with some personal work. hopefully will finish this soon

@jlsrvr
Copy link

jlsrvr commented Dec 4, 2024

Also found a work around @kytosai if you go to where the pwa is saved, then right click and show package content > contents > resources then you shoul replace the app.icns file with your icon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants