Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor command interface #41

Open
hagenburger opened this issue Aug 22, 2018 · 1 comment
Open

Refactor command interface #41

hagenburger opened this issue Aug 22, 2018 · 1 comment
Assignees
@violetadev
Labels
enhancement New feature or request good first issue Good for newcomers RGSoC This is a task for the Rails Girls Summer of Code DV Team
Milestone
v1.0.0

Comments

@hagenburger
Copy link
Owner

The current way to add a new command (Processing Instruction) <?my-command?> is:

config.commands['my-command'] = () => 'return value'

This should be refactored into:

config.commands.add('my-command', () => 'return value')
@hagenburger hagenburger added enhancement New feature or request good first issue Good for newcomers RGSoC This is a task for the Rails Girls Summer of Code DV Team labels Aug 22, 2018
@hagenburger hagenburger added this to the v1.0.0 milestone Aug 22, 2018
@violetadev
Copy link
Collaborator

Refactor command interface

@violetadev violetadev self-assigned this Sep 3, 2018
@violetadev violetadev mentioned this issue Sep 15, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@violetadev violetadev

Labels
enhancement New feature or request good first issue Good for newcomers RGSoC This is a task for the Rails Girls Summer of Code DV Team
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

This closes #41 Refactor command interface violetadev/pimd
2 participants
@hagenburger @violetadev