Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy live demo to github pages #65

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Deploy live demo to github pages #65

wants to merge 3 commits into from

Conversation

violetadev
Copy link
Collaborator

This closes #45 : deploy live demo to github pages

benevbright
benevbright requested changes Sep 23, 2018
View reviewed changes
Copy link
Collaborator

@benevbright benevbright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every code is duplicated.

@violetadev
Copy link
Collaborator Author

@benevbright what do you mean?

@benevbright
Copy link
Collaborator

https://github.com/hagenburger/pimd/blob/22e9ff380ce6acc7a6d9eb0e58314917a3fb2542/demo/gulpfile.js

This is the current code. The code is written twice.
I guess there could be some mistake when you rebase or something.

@benevbright
Copy link
Collaborator

benevbright commented Sep 23, 2018 •
edited
Loading

And could you change the title of PR?

@violetadev
Update gulpfile.js
00ecce3 
Deleted duplicated code
@violetadev violetadev changed the title This closes #45 Deploy live demo to github pages Sep 23, 2018
hagenburger
hagenburger requested changes Sep 26, 2018
View reviewed changes
Copy link
Owner

@hagenburger hagenburger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please check if the package.json and package-lock.json needs an update
  • Please check the errors raised in the CI

@benevbright
Copy link
Collaborator

benevbright commented Sep 29, 2018 •
edited
Loading

Seems like Travis issue is fixed.
So please rebase to latest master if you had trouble because of Travis.
#70

@violetadev
Update package.json
f5a319f 
Updated gulp connect version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benevbright benevbright benevbright requested changes

@hagenburger hagenburger hagenburger requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deploy live preview to GitHub Pages
3 participants
@violetadev @benevbright @hagenburger