Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish container images #100

Closed
svenstaro opened this issue Feb 15, 2024 · 11 comments · Fixed by #103
Closed

Publish container images #100

svenstaro opened this issue Feb 15, 2024 · 11 comments · Fixed by #103
Labels
enhancement New feature or request

Comments

@svenstaro
Copy link

svenstaro commented Feb 15, 2024

I really like xiu but currently deploying it is a bit tedious because I first need to compile it on my server and then start it. I think it might be more convenient if you used either DockerHub or the GitHub Container Registry to publish pre-built images (with the WebRTC web files in the right location for the binary already).

This could also solve #80 if you published multi-arch packages. You can copy parts of the process from miniserve if you like.

@harlanc harlanc added the new feature new feature label Feb 17, 2024
@rsubr
Copy link

rsubr commented Feb 23, 2024

Thanks @harlanc for the great project.

I'm a rust noob and do not have the rust knowledge or toolchain on my computer to build xiu.

Please see the attached build scripts which will create a docker container and build xiu inside it. The host machine does not need any rust tools, the entire build is inside docker. Using this build script, I have successfully built xiu on Linux x64 and aarch64.

To use, unzip the build.zip file into the repo base directory and run ./build.sh. Please consider adding build.sh and build2.sh to the repo if you find it useful.

As @svenstaro suggests having pre-built images will be fabulous. Also please consider releasing binaries on GitHub for those who want to run xiu natively without docker 🙏

Attachments: build.zip

@harlanc
Copy link
Owner

harlanc commented Feb 27, 2024

@rsubr Thanks for your new idea to build xiu, I run the script on my M1 Mac book, after the compilation process is completed, a "xiu" binary is generated on macOS, but this binary can only be run inside the docker image where xiu was compiled due to system differences, the system of docker is :

Linux beb91e124e02 5.10.47-linuxkit #1 SMP PREEMPT Sat Jul 3 21:50:16 UTC 2021 aarch64 GNU/Linux

So this script will pull a corresponding Linux version for the CPU architecture of your physical machine for compilation.,

image

right?I will consider whether to add it to the repository, thank you. 😊

@harlanc harlanc mentioned this issue Mar 2, 2024
@harlanc
Copy link
Owner

harlanc commented Mar 2, 2024

@svenstaro
Based on your GitHub Action workflow, pre-builds for some CPU architectures have been generated successfully, but the Docker image publishing failed which will be fixed in the next release. Thank you.

@svenstaro
Copy link
Author

Great to hear!

@harlanc
Copy link
Owner

harlanc commented Mar 2, 2024

@svenstaro A question about podman push in github action, where's the value of the environment variable "needs.publish.outputs.version" read from? I can retrieve the value during testing, but I don't know why I can't get it in the official release, it's empty:

image

@svenstaro
Copy link
Author

@murlakatamenka
Copy link

Since we talk about packaging and distribution here...

@svenstaro do you plan do add xiu to Arch repos or is it safe to make an AUR package?

I've been aware of it for a few years and using it from time to time, but didn't push to AUR for others.

@harlanc
Copy link
Owner

harlanc commented Mar 2, 2024

@harlanc
Copy link
Owner

harlanc commented Mar 2, 2024

Install xiu doc

@svenstaro
Copy link
Author

Since we talk about packaging and distribution here...

@svenstaro do you plan do add xiu to Arch repos or is it safe to make an AUR package?

I've been aware of it for a few years and using it from time to time, but didn't push to AUR for others.

I might push it to repos later on. Let's have it in AUR for now.

@murlakatamenka
Copy link

I might push it to repos later on. Let's have it in AUR for now.

okay, boss

https://aur.archlinux.org/packages/xiu

@harlanc harlanc added enhancement New feature or request and removed new feature new feature labels Mar 3, 2024
@harlanc harlanc linked a pull request Mar 15, 2024 that will close this issue
@harlanc harlanc closed this as completed May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants