-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manual approval between plan and apply #24
Comments
look into the |
We are attempting to using the new "requested reviewers" process for this now in Actions. Still have some things to figure out regarding the flow of it all. If it's useful I can share an actions file when we are done. |
@brettcurtis I was wondering if you arrived to any interesting conclusion about the idea using "requested reviewers" for this? |
Yeah, we ended up going all in on GitHub here. We use environments and required reviewers like I mention above. We also use called workflows in an effort to be as DRY as possible. I can share our called workflows if that would be helpful. We have a called workflow for each of the major cloud providers, GCP, AWS & Azure. |
Ah interesting! I would greatly appreciate if you shared it! Only AWS-related pipelines should suffice for me, but you can share it all if it suits you 😎 |
@TrongTheAlpaca here you go, very specific to how I use Terraform but hopefully it can give you some ideas: https://github.com/lzysh/github-terraform-called-workflows/blob/main/.github/workflows/aws-plan-and-apply-called.yml Gives us something like this (this is a pic of Google workflow but AWS is similar) allows us to have human approval between each plan and apply job: |
Has anyone found a decent way to have some sort of manual approval process between plan and apply? Between "steps" is really what I'm after. But I suppose it could even be between jobs. A job to run plan and approve followed by a job to run apply.
The text was updated successfully, but these errors were encountered: