Backport of Refactor proxy list command, ensuring api-gateway Pods are included into release/1.4.x
#4428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-consul-core
force-pushed
the
backport/fix-list-proxies-api-gateway/apparently-renewing-goblin
branch
from
005efc0 to
6f7233a
Compare
nathancoleman
approved these changes
Nov 19, 2024
hc-github-team-consul-core
merged commit 2c5831f
into
release/1.4.x
48 of 49 checks passed
hc-github-team-consul-core
deleted the
backport/fix-list-proxies-api-gateway/apparently-renewing-goblin
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #4426 to be assessed for backporting due to the inclusion of the label backport/1.4.x.
The below text is copied from the body of the original PR.
Changes proposed in this PR
proxy listcommand where they were not before due to a helm chart label that wasn't present. It doesn't make sense to include this label on created API gateways since they are not actually controlled by the helm chart.How I've tested this PR
Install an assortment of gateways and mesh-injected services, verify output matches (
go run ./cli proxy list -all-namespaces, for example)How I expect reviewers to test this PR
See above
Checklist
Overview of commits