-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: data_source vault_transit_secret_backend_key #2327
base: main
Are you sure you want to change the base?
feat: data_source vault_transit_secret_backend_key #2327
Conversation
ed8d5f2
to
859031f
Compare
859031f
to
2173beb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A great start to this @simonostendorf, thanks!
I've added a comment about keys that are missing and we are also missing the associated documentation updates for the new data source.
ForceNew: true, | ||
Description: "Name of the key.", | ||
}, | ||
"type": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few keys missing from this
- auto_rotate_period
- imported_key (it's listed as imported below)
- latest_version
- min_available_version
There are also a few optional keys depending on options set in the response returned see formatKeyPolicy
- key_size is returned if set on creation
- imported_key_allow_rotation is returned if imported_key is true
- backup_info and restore_info are returned if the key was backed up/restored
- kdf, kdf_mode, convergent_encryption and possibly convergent_encryption_version are returned if derived is true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few keys missing from this
Sorry I used an old vault release without some of these keys and after testing it with the new version I forgot to add them.
Thanks for your review, after testing with the latest Vault version I noticed that there are no more key details in the api response. But that was the reason I wanted this data source. I can try to finish this PR, but I can not say how long it will take, because it can no longer fulfil my goal. |
Description
Add
vault_transit_secret_backend_key
data source.Closes #2326
Checklist
Output from acceptance testing:
Community Note