Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a current thread ID to the hls log. #4172

Closed
soulomoon opened this issue Apr 13, 2024 · 1 comment · Fixed by #4174
Closed

Adding a current thread ID to the hls log. #4172

soulomoon opened this issue Apr 13, 2024 · 1 comment · Fixed by #4174
Labels
type: enhancement New feature or request

Comments

@soulomoon
Copy link
Collaborator

soulomoon commented Apr 13, 2024

When I am trying to fix #4152,
I added a current thread ID to the logger,
I find it can give us an effective debugging eperience on race issues.
Any reason against it. I would like some opinions on this

Something like this

ThreadId 19 | 2024-04-11T03:17:33.383209Z | Info | Started LSP server in 0.01s
ThreadId 19 | 2024-04-11T03:17:33.452743Z | Debug | ghc --print-libdir
ThreadId 19 | 2024-04-11T03:17:33.453779Z | Debug | Setting initial dynflags...
ThreadId 19 | 2024-04-11T03:17:33.453819Z | Debug | shouldRunSubset: True
ThreadId 29 | 2024-04-11T03:17:33.453879Z | Debug | Initializing exports map from hiedb
ThreadId 29 | 2024-04-11T03:17:33.454034Z | Debug | Done initializing exports map from hiedb. Size: 0
@soulomoon soulomoon added the type: enhancement New feature or request label Apr 13, 2024
@fendor
Copy link
Collaborator

fendor commented Apr 14, 2024

Sounds good to me and should be easy enough to add. Perhaps it is not that useful for normal user logs, but at least for tests we can enable it unconditionally, imo.

@soulomoon soulomoon linked a pull request Apr 14, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants