Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent argument order between backward.h and backward.cu #28

Open
19reborn opened this issue Dec 4, 2024 · 1 comment
Open

Inconsistent argument order between backward.h and backward.cu #28

19reborn opened this issue Dec 4, 2024 · 1 comment

Comments

@19reborn
Copy link

19reborn commented Dec 4, 2024

Thanks for your excellent work. I noticed a potential inconsistency in the render function between backward.h and backward.cu.

Specifically:

  • In lines 700 and 701 of backward.cu, the order of parameters has colors first, followed by transMats.
  • However, in the backward.h definition, their order is reversed.

While this discrepancy likely doesn't cause any bugs during execution, it might lead to confusion or misunderstandings for those reading or attempting to re-implement your code.

Thank you for your attention.

@hbb1
Copy link
Owner

hbb1 commented Dec 10, 2024

Ohh, a good catch! Let me fix that in the next update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants