Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no tools directory #1169

Closed
yibuyisheng opened this issue May 9, 2016 · 4 comments
Closed

no tools directory #1169

yibuyisheng opened this issue May 9, 2016 · 4 comments

Comments

@yibuyisheng
Copy link

There was no tools directory when I installed this library by npm install highlight.js, so I can not use the tools/build script to build for browsers.

@derhuerst
Copy link

The GitHub repo contains the tools dir. Also, check the highlight.js website.

@yibuyisheng
Copy link
Author

@derhuerst Thanks for your answer.

I know what you mean. There are two workarounds:

    1. npm install isagalaev/highlight.js --save, then I have a tools dir.
    1. Download the highlight.min.js, and use the script tag to import it.

But my project is based on npm modules, so the two workarounds look really ugly.

I think the most perfect way is to publish the highlight.pack.js to npm too.

@derhuerst
Copy link

I know what you mean. There are two workarounds:

  1. npm install isagalaev/highlight.js --save, then I have a tools dir.
  2. Download the highlight.min.js, and use the script tag to import it.

Or use a git submodule and build the highlight.js on the fly.

But my project is based on npm modules, so the two workarounds look really ugly.

I'd also like highlight.js to be many small modules, as that is the common practice in the npm eco system. See #1086.

I think the most perfect way is to publish the highlight.pack.js to npm too.

I strongly disagree. There is a point in npm just serving the distribution files, as custom builds seems to get less common (because of small composable modules).

There's terabytes of traffic and hours or time being wasted because npm modules that have more files than necessay.

@Sannis Sannis added the other label May 9, 2016
@isagalaev
Copy link
Member

The purpose of highlight.js on npm is to be installed and used as a library, it's not a source code distribution. Source code is hosted on GitHub. We don't intend to support every imaginable way of getting either source or binary distribution from everywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants