Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ch07l006 - Useless assertion #113

Open
HelloThisIsFlo opened this issue Nov 14, 2019 · 2 comments
Open

ch07l006 - Useless assertion #113

HelloThisIsFlo opened this issue Nov 14, 2019 · 2 comments

Comments

@HelloThisIsFlo
Copy link

In ch07l006, there is an useless assertion that sneaked in.

Basically, that test:

self.assertNotIn('make a fly', page_text)

is useless because in test_multiple_users_can_start_lists_at_different_urls Edith did not create a second list item with ...make a fly. So that particular assertion would never fail and just brings a little bit of confusion.

@jwm-evans
Copy link
Contributor

ch07|006 is a continuation of ch07l005, where Edith did create such an item. The thing being tested here is that Edith's list items don't appear in Francis' list.

@HelloThisIsFlo
Copy link
Author

In ch07l005, there are 2 tests:

  • test_can_start_a_list_for_one_user
  • test_multiple_users_can_start_lists_at_different_urls

ch07|006 is indeed a continuation of ch07|005, but it is a continuation of the second test of ch07|005: test_multiple_users_can_start_lists_at_different_urls

And in test_multiple_users_can_start_lists_at_different_urls Edith does not create the second item.

ch07|005

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants