Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include peer IDs on the DHT? #4

Open
pfrazee opened this issue Oct 6, 2018 · 4 comments
Open

Include peer IDs on the DHT? #4

pfrazee opened this issue Oct 6, 2018 · 4 comments
Labels
discussion Not a bug, feature request, or enhancement

Comments

@pfrazee
Copy link
Contributor

pfrazee commented Oct 6, 2018

"Peer IDs" are used solely to deduplicate connections. If they were present on the DHT, we could avoid even attempting to connect to a peer which we've already connected to.

Things to consider:

  • Could choosing peer ID be used to attack somebody? Eg, announce under somebody else's peer ID to effectively DoS them.
@pfrazee pfrazee added the discussion Not a bug, feature request, or enhancement label Oct 6, 2018
@pfrazee
Copy link
Contributor Author

pfrazee commented Oct 6, 2018

We could use hash(IP + port) for the Peer ID so that they're not choosable.

@pfrazee
Copy link
Contributor Author

pfrazee commented Oct 6, 2018

Though- if we're using hash(IP + port) that's information we already know. We already avoid connecting to IP/ports that we're already connected to.

Peer IDs are supposed to be a way to detect when the peer is == when the IP/port is different, eg due to ipv6 vs ipv4 or public vs lan, right?

@maxmetagravity
Copy link

i think we can choose that options, default is ID open on DHT

@Nuhvi
Copy link

Nuhvi commented Jan 31, 2022

Is this the reason why the @next version removed the deduplication logic from peer-info ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Not a bug, feature request, or enhancement
Projects
None yet
Development

No branches or pull requests

3 participants