Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refinery] Refinery uses hard-coded ports in the deployment.yaml #230

Open
TylerHelmuth opened this issue Mar 20, 2023 · 0 comments
Open
Assignees
Labels
type: bug Something isn't working

Comments

@TylerHelmuth
Copy link
Contributor

The refinery helm chart hard codes the deployment port values. This means changes to the ListenAddr, GRPCListenAddress, or service ports will not work as expected.

We should change these lines to honor service port values changes:

ports:
- name: data
containerPort: 8080
protocol: TCP
- name: grpc
containerPort: 4317
protocol: TCP
- name: peer
containerPort: 8081
protocol: TCP
{{- if eq .Values.config.Metrics "prometheus" }}
- name: metrics
containerPort: 9090
protocol: TCP
{{- end }}

@TylerHelmuth TylerHelmuth added the type: bug Something isn't working label Mar 20, 2023
@fchikwekwe fchikwekwe self-assigned this Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants