Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows 10 support. #10

Open
zw5 opened this issue May 29, 2020 · 3 comments
Open

Windows 10 support. #10

zw5 opened this issue May 29, 2020 · 3 comments
Labels

Comments

@zw5
Copy link

zw5 commented May 29, 2020

Windows 10 support is broken as of python 3.8 now thanks to the event loop policy changing. Any plans on fixing this?

@horazont
Copy link
Owner

@creator1372 Thanks for the report.

Unfortunately, I don’t have a Windows machine at all. So I can’t even see the error message or the problematic behaviour without a report.

I’d be interested in improving windows support if someone would help with these things and testing.

@horazont horazont added the bug label May 30, 2020
@zw5
Copy link
Author

zw5 commented Jun 1, 2020

well, it's actually a pretty easy fix. The new event loop in python 3.7 is ProactorEventLoop which doesn't support loop.add_reader and loop.remove_reader. Fixing it should be as easy as adding this at the top of all the files in the project.

import os

if os.name == "nt":
    asyncio.set_event_loop_policy(asyncio.WindowsSelectorEventLoopPolicy())

@horazont
Copy link
Owner

horazont commented Jun 1, 2020

@creator1372 This is something users should do then.

However, if the Proactor event loop can, with stock asyncio, do TLS, then this should be fixed. As I don’t have the systems required to develop and test it, it’s rather unlikely to happen.

I’ll leave this open so that others can find the workaround.

(Alternatively, someone should check if the stock asyncio TLS support can by now do all the things aioopenssl can do, in which case this package can simply be retired.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants