feat: add member list to detail view #376
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
TobiPeterG
commented
Jan 31, 2023
Comment on lines
+36
to
+38
| <% else %> | ||
| <td> | ||
| </td> |
There was a problem hiding this comment.
Is this worth an extra issue?
There was a problem hiding this comment.
I think its fine just fixing it here
DieKautz
requested changes
Feb 1, 2023
Comment on lines
+13
to
+39
| <table class="table table-bordered"> | ||
| <thead> | ||
| <tr> | ||
| <th scope="col"><%= t(:member_name) %></th> | ||
| <th scope="col"><%= t(:member_email) %></th> | ||
| <th scope="col" style="width: 3rem"></th> | ||
| </tr> | ||
| </thead> | ||
| <tbody class="table-group-divider"> | ||
| <% @group.users.each do |user| %> | ||
| <tr> | ||
| <td><%= user.full_name %></td> | ||
| <td><%= user.email %></td> | ||
| <% if not user.admin_in?(@group) %> | ||
| <td> | ||
| <%= mail_to user.email, class: "btn btn-sm btn-secondary" do %> | ||
| <i class="bi bi-chat-fill"></i> | ||
| <% end %> | ||
| </td> | ||
| <% else %> | ||
| <td> | ||
| </td> | ||
| <% end %> | ||
| </tr> | ||
| <% end %> | ||
| </tbody> | ||
| </table> |
There was a problem hiding this comment.
This is copied from edit.html.erb right?, would it be an option to make use of components/fragments to minimize duplication?
| @@ -10,3 +10,30 @@ | |||
| <%= t('items.headlines.items') %> | |||
| </h5> | |||
| <%= render GroupItemListComponent.new(group: @group) %> | |||
| <table class="table table-bordered"> | |||
There was a problem hiding this comment.
The member count should also be displayed as seen in the wireframe.
Also already done in edit.html.erb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #318