Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sw3: GameItem Standardization and Serialization #3

Open
hqkirkland opened this issue Oct 18, 2020 · 0 comments
Open

sw3: GameItem Standardization and Serialization #3

hqkirkland opened this issue Oct 18, 2020 · 0 comments

Comments

@hqkirkland
Copy link
Owner

hqkirkland commented Oct 18, 2020

ClothingItem and AvatarItem aren't great separators: they're basically the same thing, except AvatarItem is a typedef with extra game client-specific data (file path, item color). Here, AvatarItem serves as the best model for what an "owned item" should look like vs. a general, non-owned GameItem concept.

GameItem class should be built from the ClothingItem class.
ClientData.clothingItems should be set by filtering GameItems into it by clothing type.
Inventory.wardrobe should be a set of all GameItems that the user OWNS, each translated into an AvatarItem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant