Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alignment Question #8

Open
sshleifer opened this issue Jul 25, 2019 · 0 comments
Open

Alignment Question #8

sshleifer opened this issue Jul 25, 2019 · 0 comments

Comments

@sshleifer
Copy link

sshleifer commented Jul 25, 2019 •
edited
Loading

Thanks so much for this repo!
In custom_collate_fn: (https://github.com/hsgodhia/hred/blob/master/util.py#L72)
We

return u1_batch[sort1, :], u1_lens[sort1], u2_batch[sort2, :], u2_lens[sort2], u3_batch[sort3, :], u3_lens[sort3]

Doesn't this imply that our [d1,d2,d3] DialogTurns will not be aligned when we, somewhat later, call,
qu_seq = torch.cat((o1, o2), 1)

(https://github.com/hsgodhia/hred/blob/master/modules.py#L39)

When do we unsort?
Thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sshleifer