-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quantizing Falcon Instruct Model fails at tgi 0.9.0 #552
Comments
I think 2 A100 will not fit 40B in its entirety (and apparently not even in CPU RAM). The tensor being |
Okay. That would be great and only a minor problem. I will try it out and give you a hint. |
Can you try the latest, version. I just merged an upgrade to the quantization script: #587 It should use barely and VRAM at all now. |
I can confirm that with #587 and release v0.9.3 the issue is fixed. I was able to quantize the model with one A100 (40GB) and a limit of 128 GB ram. However, in the following code snippets seems to be a bug. The trust_remote_code variable is not passed to text-generation-inference/server/text_generation_server/utils/gptq/quantize.py Lines 866 to 868 in b3f830a
It should be changed to: with init_empty_weights():
model = AutoModelForCausalLM.from_config(config, torch_dtype=torch.float16,trust_remote_code=trust_remote_code)
model = model.eval() I made a MR see below. |
# What does this PR do? <!-- Congratulations! You've made it this far! You're not quite done yet though. Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution. Then, please replace this with a description of the change and which issue is fixed (if applicable). Please also include relevant motivation and context. List any dependencies (if any) that are required for this change. Once you're done, someone will review your PR shortly (see the section "Who can review?" below to tag some potential reviewers). They may suggest changes to make the code even better. If no one reviewed your PR after a week has passed, don't hesitate to post a new comment @-mentioning the same persons---sometimes notifications get lost. --> <!-- Remove if not applicable --> Fixes a bug appeared with MR #587 fixing issue #552. See the discussion in #552. With MR #587 the trust_remote_code variable is not passed to AutoModelForCausalLM, but is found in the function signature. This prevents models like falcon to be quantized, because trust_remote_code is required. This MR fixes the issue. ## Before submitting - [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case). - [X] Did you read the [contributor guideline](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md#start-contributing-pull-requests), Pull Request section? - [X] Was this discussed/approved via a Github issue or the [forum](https://discuss.huggingface.co/)? Please add a link to it if that's the case. - [ ] Did you make sure to update the documentation with your changes? Here are the [documentation guidelines](https://github.com/huggingface/transformers/tree/main/docs), and [here are tips on formatting docstrings](https://github.com/huggingface/transformers/tree/main/docs#writing-source-documentation). - [ ] Did you write any new necessary tests? ## Who can review? Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR. @Narsil <!-- Your PR will be replied to more quickly if you can figure out the right person to tag with @ -->
System Info
text-generation-inference: 0.9.0
Target: x86_64-unknown-linux-gnu
Cargo version: 1.70.0
Commit sha: e28a809
Docker label: sha-e28a809
nvidia-smi:
Information
Tasks
Reproduction
Steps to reproduce:
Error Appearance:
NotImplementedError: Cannot copy out of meta tensor; no data!
Log:
Expected behavior
Quantized model is saved at
/data/falcon-40b-oasst-gtpq
The text was updated successfully, but these errors were encountered: