Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] AMOLED Black Mode #7

Open
emmatebibyte opened this issue Aug 30, 2020 · 10 comments
Open

[Feature Request] AMOLED Black Mode #7

emmatebibyte opened this issue Aug 30, 2020 · 10 comments

Comments

@emmatebibyte
Copy link

I just want to say I love the app, but the interface is only light mode. It's not a big issue, but an AMOLED black mode would be perfect :)

@hugomg
Copy link
Owner

hugomg commented Aug 30, 2020

Thanks for the suggestion. Are you talking about the Android 10 feature? https://developer.android.com/guide/topics/ui/look-and-feel/darktheme

@emmatebibyte
Copy link
Author

Yes, exactly :) the app and the popup are light mode, which hurts my eyes since I use only dark mode apps. Plus I have an AMOLED screen which can suffer burn-in and battery loss from light themes.

@TPS
Copy link

TPS commented Sep 2, 2020

@tib-emma Have you tried Override force-dark? Note that the setting doesn't survive reboots.

@emmatebibyte
Copy link
Author

Force dark mode doesn't cause the app to be AMOLED black (hex #000000). See attached image. I also have my phone perform a reboot nightly to help with performance, so this solution is very inconvenient.
Screenshot_20200902-171412_Daily Pill

@hugomg
Copy link
Owner

hugomg commented Sep 3, 2020

I implemented dark mode (non AMOLED) for the next version of Daily Pill. Could you help me test if it is working? You can get version 1.3.1 by signing up for beta testing on the Play Store page for the app or you can get the APK from the github releases page

As for the AMOLED black thing, would it be possible to do something on your phone to make all dark theme use #000000 as a background color? It feels a bit strange to have to add this kind of functionality to Daily Pill in particular when it sounds like it would be more useful if you were able to change the system defaults.

@TPS
Copy link

TPS commented Sep 4, 2020

[Sign] up for beta testing on the Play Store page for the app

On any browser that 1 can sign into their Google Play account, https://play.google.com/apps/testing/br.com.gualandi.dailypill will allow to sign up for testing versions directly.

@hugomg
Copy link
Owner

hugomg commented Sep 4, 2020 via email

@emmatebibyte
Copy link
Author

I implemented dark mode (non AMOLED) for the next version of Daily Pill. Could you help me test if it is working? You can get version 1.3.1 by signing up for beta testing on the Play Store page for the app or you can get the APK from the github releases page

As for the AMOLED black thing, would it be possible to do something on your phone to make all dark theme use #000000 as a background color? It feels a bit strange to have to add this kind of functionality to Daily Pill in particular when it sounds like it would be more useful if you were able to change the system defaults.

I am unfortunately unaware of any settings that do this, but if you know of anything, please let me know!

@hugomg
Copy link
Owner

hugomg commented Sep 8, 2020

Googling a bit more, it really seems like the only way to add "super dark" mode is inside the app itself. Ugh, how inconvenient!

I don't know how this could be implemented but I'd be open to merging a pull request if someone else can figure out a way to do it.
Another thing that could be helpful is if someone could make a list of some other apps on F-Droid that implement an "AMOLED optimized" dark mode. The source code for those could be used as an example.

By the way, were you able to try the current implementation of dark mode? I'm curious if it is working...

@emmatebibyte
Copy link
Author

By the way, were you able to try the current implementation of dark mode? I'm curious if it is working...

Yes, I was, and it works perfectly! I'll post some good examples of AMOLED implementation here later today :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants