You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Either host the releases.json file somewhere (or even a very simple API to query the links), and we make a GET request call whenever we want to check for the versions.
Find a repetitive pattern for the links and look for them dynamically when detecting a version in contracts:
For Linux binaries for example: https://github.com/ethereum/solidity/releases/download/v<version>/solc-static-linux seems to work
This would make our releases easier and also avoid the issues we're getting from users depending on libraries that use the latest solidity versions.
The text was updated successfully, but these errors were encountered:
Adding the good first issue label as the repetitive pattern mechanism is easy to implement while we think of a better solution or go for the hosted mechanism.
And, we can use the first proposed resolve mechanism. We can just use the list file: https://binaries.soliditylang.org/<platform>list.json and create the download link: https://binaries.soliditylang.org/<platform>/<path>.
So, this change makes sense.
Edit: Just thought about it more, we can do it without. Will update the above description to accommodate.
Edit2: Keeping the good first issue as this can be tackled without much context.
Currently, we're using https://github.com/web3j/web3j-sokt/blob/master/src/main/resources/releases.json to install solidity.
This is not good as we need to release new versions of sokt, and most of the other libraries, whenever we have a new solc version so that we're up-to-date.
I suggest we:
releases.json
file somewhere (or even a very simple API to query the links), and we make a GET request call whenever we want to check for the versions.https://github.com/ethereum/solidity/releases/download/v<version>/solc-static-linux
seems to workThis would make our releases easier and also avoid the issues we're getting from users depending on libraries that use the latest solidity versions.
The text was updated successfully, but these errors were encountered: