Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update generated key with latest timestamp when index is changed #325

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

josephprem
Copy link

No description provided.

@hypnoglow hypnoglow changed the title rebased with master Update generated key with latest timestamp when index is changed Nov 2, 2023
Copy link
Owner

@hypnoglow hypnoglow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I propose a few changes, everything else looks good.

go.sum Outdated Show resolved Hide resolved
internal/helmutil/index_v2.go Outdated Show resolved Hide resolved
plugin.yaml Outdated Show resolved Hide resolved
@hypnoglow hypnoglow added this to the 0.16.0 milestone Nov 2, 2023
internal/helmutil/index_v2_test.go Outdated Show resolved Hide resolved
internal/helmutil/index_v2.go Outdated Show resolved Hide resolved
internal/helmutil/index_v3.go Outdated Show resolved Hide resolved
internal/helmutil/index_v3_test.go Outdated Show resolved Hide resolved
cmd/helm-s3/push.go Outdated Show resolved Hide resolved
@hypnoglow hypnoglow modified the milestones: 0.16.0, Next Dec 6, 2023
@hypnoglow
Copy link
Owner

Fixes #142

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.91%. Comparing base (8003012) to head (9e920a8).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #325      +/-   ##
==========================================
+ Coverage   41.45%   41.91%   +0.45%     
==========================================
  Files          19       19              
  Lines         509      513       +4     
==========================================
+ Hits          211      215       +4     
  Misses        288      288              
  Partials       10       10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hypnoglow
Copy link
Owner

Hey, I made a few changes I proposed previously. Thank you again for the contribution.

@hypnoglow hypnoglow merged commit f2dded8 into hypnoglow:master Mar 12, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants