-
-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Escaping Issues #316
Comments
you can build your own function: https://github.com/i18next/i18next-xhr-backend/blob/master/src/index.js#L29 |
Thanks for the hint. Do you agree that things should be properly escaped as a default though? |
got no opinion on that...namespaces should be simple - so your case is the first in 7 years... backends are extra done as plugins to feel needs as user demand...personally I would completely remove multiload |
This would for example be a problem if the namespace names are not in English (which makes sense if the default language is not English) or if they contain spaces. I agree that it's an unfortunate choice for namespaces to contain spaces… Note that only the escaping of spaces is a problem in the multiload scenario. The general escaping of HTML entities is a problem in the normal code path as well. Let me try to propose a PR to improve the situation and we can discuss things further :) |
The implementation of
readMulti
builds the resulting URL by joining arguments withThis causes trouble for me when the namespace contains whitespaces as these can the not be recovered correctly on the backend.
More generally, this is problematic when the namespace contains anything that gets escaped by
interpolate
. Characters seem to get escaped as the HTML entities which is very confusing to parse on the backend since you would expect URL escaped arguments.The text was updated successfully, but these errors were encountered: