Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Having a dash "-" in the input with no date returns a daily occurrence beginning w/ the current day #26

Open
chelsea opened this issue Aug 28, 2014 · 0 comments

Comments

@chelsea
Copy link

chelsea commented Aug 28, 2014

This carries on from lzell/nickel#7

Messages with no time information which contain a dash return a time instance when they should not.

Nickel.parse("Hey guys - let's do the thing")
=> message: "Hey guys lets do the thing", occurrences: [#<Occurrence type: daily, start_date: 20140828, interval: 1>]

Would expect that no time information would be parsed in the above message.

The replace_hyphens method automatically replaces all hyphens and does not allow for their use for anything other than describing date ranges: https://github.com/iainbeeston/nickel/blob/master/lib/nickel/nlp_query.rb#L388-L390

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant