Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should 'prop-types' be a dependency? #45

Open
araguma opened this issue Feb 6, 2024 · 0 comments
Open

Should 'prop-types' be a dependency? #45

araguma opened this issue Feb 6, 2024 · 0 comments

Comments

@araguma
Copy link

araguma commented Feb 6, 2024

If I don't have prop-types under packages in package-lock.json, I get this error when I try to load any feather icons:

Import trace for requested module:
./node_modules/feather-icons-react/build/index.js
./src/app/page.tsx
 ⨯ ./node_modules/feather-icons-react/build/FeatherIcon.js:10:40
Module not found: Can't resolve 'prop-types'

This can be reproduced by running npx create-next-app@latest and declining the 'use ESLint' option since it adds prop-types as a dependency. page.tsx can be something like this:

import FeatherIcon from "feather-icons-react";

export default function Home() {
    return (
        <FeatherIcon icon="feather" />
    );
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant