New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should use Inventory Item "PrettyName" for Redfish Name #3158

Closed

gtmills opened this issue May 7, 2021 · 6 comments

Assignees

Labels

Downstream In Review

Milestone

gtmills commented May 7, 2021 •

edited

Loading

openbmc/bmcweb#204

We should look for PrettyName and if it isn't there fall back to the last segment of the URI

https://ibm-systems-power.slack.com/archives/C1HT3FHNK/p1620407582169500?thread_ts=1620123529.115600&cid=C1HT3FHNK

https://github.com/openbmc/phosphor-dbus-interfaces/blob/495981805244269650bee13d1ee8f13543b2bc5a/xyz/openbmc_project/Inventory/Item.interface.yaml#L5

See review: https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/40158

This should be a series of commits

gtmills added this to the A.1.212.5 milestone

gtmills changed the title ~~Should use Inventory Item "PrettyName"~~ Should use Inventory Item "PrettyName" for Redfish Name

gtmills assigned patelabhishek9893

Author

gtmills commented May 10, 2021

https://github.ibm.com/openbmc/bmcweb/pull/143

https://ibm-systems-power.slack.com/archives/G3WAVQYTH/p1620659600330800?thread_ts=1620659278.328800&cid=G3WAVQYTH

https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/40158

gtmills modified the milestones: A.1.212.5, A.1.212.6

gtmills assigned aahmed-2 and unassigned patelabhishek9893

Author

gtmills commented Jul 20, 2021

Google has a review here: https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/43967
@aahmed-2 owns helping drive in

aahmed-2 added the In Review label

aahmed-2 commented Sep 14, 2021

Downstream PR here: ibm-openbmc/bmcweb#93

aahmed-2 added Downstream In Review and removed In Review labels

aahmed-2 commented Sep 15, 2021

Code review in driver

Contributor

mzipse commented Jun 1, 2022

refresh again

Contributor

mzipse commented Nov 8, 2022

Closing. Work is complete.

mzipse closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment