Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SetWindowNotFoundHandler similarly SetAppRootHandler in server #47

Open
Garykom opened this issue May 5, 2019 · 1 comment
Open

Comments

@Garykom
Copy link

Garykom commented May 5, 2019

In server.go in serveHTTP there is a code:

	if win == nil {
		// Invalid window name, render an error message with a link to the window list
		w.Header().Set("Content-Type", "text/html; charset=utf-8")
		w.WriteHeader(http.StatusNotFound)
		NewWriter(w).Writess("<html><body>Window for name <b>'", winName, `'</b> not found. See the <a href="`, s.appPath, `">Window list</a>.</body></html>`)
		return
	}

Please make an opportunity to appoint the handler for formation of the page of a nonexistent window.

@icza
Copy link
Owner

icza commented May 6, 2019

I see no problem adding this. Will do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants