-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generic project name not robust to all user input #131
Comments
If you agree that a box not managed by BSF should not use a conf in ideascube then I implement this otherwise we should create a parameter. |
No it doesn't. It detects an Ideascube configuration file named after the box. That's not specific to BSF at all, it's how Ideascube is supposed to be configured at the moment. (yes, that's unfortunate, but it's what we have to work with, until we eventually change all that and make it much saner) |
As @bochecha pointed it out, https://github.com/ideascube/ansiblecube/blob/oneUpdateFile/roles/ideascube/tasks/ideascube.yml#L76-L79 is there only to verify if an ideascube configuration file exist regarding the ansiblecube hostname. If no file is found, it fall-back on generic configuration file for ideasbox and koombook |
@fheslouin do you think that maybe what @thiolliere needs is to add a third type of fallback for his pibox? |
If the fall-back configuration file does not fit the needs, we can create an ideascube configuration file matching the needs of @thiolliere then add a test case in |
I thing that if a user use a hostname that correspond with a BSF machine but launch with managed_by_bsf to False there is still issue.
the following rule detect a bsf conf file. we should add to the conditional the managed_by_bsf parameter.
https://github.com/ideascube/ansiblecube/blob/oneUpdateFile/roles/ideascube/tasks/ideascube.yml#L76-L79
I think this part may be wrong and reworked
The text was updated successfully, but these errors were encountered: