Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sessions are only needed when logged in #129

Open
imjoehaines opened this issue Nov 11, 2018 · 0 comments
Open

Sessions are only needed when logged in #129

imjoehaines opened this issue Nov 11, 2018 · 0 comments

Comments

@imjoehaines
Copy link
Owner

Right now we call session_start in index.php

sihae/public/index.php

Lines 29 to 38 in e21b21e

session_start([
'name' => 'Sihae',
'use_strict_mode' => true,
'use_only_cookies' => true,
'gc_maxlifetime' => 60 * 15,
'cookie_lifetime' => 0,
'cookie_httponly' => true,
'sid_length' => 64,
'sid_bits_per_character' => 6,
]);

but we only need a session when a user is logged in; can we only start a session when logging someone in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant