Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc-web: Importing as ESModule in Node #1171

Open
tommie opened this issue Jul 13, 2023 · 1 comment
Open

grpc-web: Importing as ESModule in Node #1171

tommie opened this issue Jul 13, 2023 · 1 comment

Comments

@tommie
Copy link

tommie commented Jul 13, 2023

Versions of relevant software used

  • Node v19
  • grpc-web v1.5.1
  • webpack: 5.88.1
  • webpack-cli: 4.10.0

What happened

Similar to #369, attempting to run this (named repro.mjs) under Node fails:

import { grpc } from "@improbable-eng/grpc-web";

with

import { grpc } from "@improbable-eng/grpc-web";                                             
         ^^^^                    
SyntaxError: Named export 'grpc' not found. The requested module '@improbable-eng/grpc-web' is a CommonJS module, which may not support all module.exports as named exports.               
CommonJS modules can always be imported via the default export, for example using:           

What you expected to happen

No error.

How to reproduce it (as minimally and precisely as possible):

https://stackblitz.com/edit/stackblitz-webcontainer-api-starter-uuifs3?file=repro.js&view=editor

Run npm run repro

It looks like building for ESM (as originally suggested in #369) and adding an exports.import field in package.json makes it importable: https://github.com/improbable-eng/grpc-web/compare/master...tommie:grpc-web:esm?expand=1

@andriy-bilyak
Copy link

Any solutions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants