Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe: avoid waitForStateComplete workflow getting timeout #519

Open
longquanzheng opened this issue Dec 12, 2024 · 0 comments
Open

Maybe: avoid waitForStateComplete workflow getting timeout #519

longquanzheng opened this issue Dec 12, 2024 · 0 comments

Comments

@longquanzheng
Copy link
Contributor

Use a timer after workflow start. When the timer fired and signal is not received yet, failed the workflow.

This will help to not get timeout metrics for the namespace.

And also prevent an extremely rare edge case that the workflow will get timeout at the same time of receiving the signal…

However, always starting a timer is expensive…

The best way is to implement the V2 #349

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant