Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always use local activities for sync update based RPC #522

Open
longquanzheng opened this issue Dec 15, 2024 · 0 comments
Open

Always use local activities for sync update based RPC #522

longquanzheng opened this issue Dec 15, 2024 · 0 comments

Comments

@longquanzheng
Copy link
Contributor

longquanzheng commented Dec 15, 2024

Context
Today, whenever an RPC needs locking, we will use sync update of Temporal to process:

if needLocking(req) {

Within the sync update, we use an activity to invoke worker RPC API:

err = u.provider.ExecuteActivity(&activityOutput, u.configer.ShouldOptimizeActivity(), ctx,

The activity will choose to use local activity or regular based on workflow config.

However, the config can be ignored and always use local activity, because there is no side effect of using local activity for this case, but only benefits. The latency will be lower with LA, and saving the storage cost becaues omitting the activity input in LA.

Goal
Update the workflowUpdate to always use local activity.

Note:

  • Needs a versioning because this is not determinstic change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant