Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversion from shaaradaa is broken #63

Open
grosmar opened this issue Aug 24, 2023 · 0 comments
Open

Conversion from shaaradaa is broken #63

grosmar opened this issue Aug 24, 2023 · 0 comments

Comments

@grosmar
Copy link
Contributor

grosmar commented Aug 24, 2023

If you try to convert sharada to anything, it is broken.
Prbobably the reason is that, the sharada characters are represented not only on one byte, but on 2 or more.https://github.com/indic-transliteration/common_maps/blob/master/brahmic/sharada.toml

image

I don't know if there is a sharada map which works with single bytes? if not, then the matchings should be changed from charAt to some more sophisticated (and problematic) solution:
https://github.com/indic-transliteration/sanscript.js/blob/master/src/sanscript.js#L375

If the sharada consistenly made of 2 bytes, then it could be marked in the mapping, and use substring instead of charAt. If not, then we need to find if there is matching string in the mapping to the beginning of the examined string, and cut always from the beginning the found character

@grosmar grosmar changed the title Conversion from shaarada is broken Conversion from shaaradaa is broken Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant