You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, the webapi in DESDEO2 (and also the old webapi) has important networking settings hard coded, like the web address where the database is located.
The information needed to connect to the database is the biggest offender here, because the database usernames and passwords should never be uploaded to github.
I would like these things to be read from environment variables. That way it would be very easy to provide the necessary information when hosting webapi on a system like kubernetes. It is also possible to provide them as a part of a command line argument or bat/shell script when running webapi somewhere else. The code could still use some default values, like localhost etc. when then environment variables haven't been defined.
A config file of some kind would be another alternative, but not as good in my opinion, because those config files would need to be stored somewhere as well, so the problem of storing database usernames and passwords on the open internet would remain.
The text was updated successfully, but these errors were encountered:
The webapi configs are now all in one place in desdeo/api/config.py, and I think all the other code is using those values as well. The default values in the config file can also be overridden with env variables, so I think this issue is mostly solved.
Currently, the webapi in DESDEO2 (and also the old webapi) has important networking settings hard coded, like the web address where the database is located.
The information needed to connect to the database is the biggest offender here, because the database usernames and passwords should never be uploaded to github.
I would like these things to be read from environment variables. That way it would be very easy to provide the necessary information when hosting webapi on a system like kubernetes. It is also possible to provide them as a part of a command line argument or bat/shell script when running webapi somewhere else. The code could still use some default values, like localhost etc. when then environment variables haven't been defined.
A config file of some kind would be another alternative, but not as good in my opinion, because those config files would need to be stored somewhere as well, so the problem of storing database usernames and passwords on the open internet would remain.
The text was updated successfully, but these errors were encountered: