You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Consistency: When initializing a class or calling a method with both an ideal and a nadir value, the ideal value should always preceed the nadir value
#23
Open
gialmisi opened this issue
Aug 6, 2021
· 0 comments
At the moment, in some places, where calling a method or initializing a class is done using both an ideal and a nadir value, the order of the values in the call signature varies. I.e., sometimes the nadir is first and sometimes the ideal. This can, and has, led to annoying bugs. Therefore, it should be fixed.
For example, instances with
def foo(nadir, ideal, ...):
...
should be changed to
def foo(ideal, nadir, ...):
...
This is an easy fix. I am documenting it here so somebody can address it in due time.
The text was updated successfully, but these errors were encountered:
At the moment, in some places, where calling a method or initializing a class is done using both an ideal and a nadir value, the order of the values in the call signature varies. I.e., sometimes the nadir is first and sometimes the ideal. This can, and has, led to annoying bugs. Therefore, it should be fixed.
For example, instances with
should be changed to
This is an easy fix. I am documenting it here so somebody can address it in due time.
The text was updated successfully, but these errors were encountered: