Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links/ href in Statuses not decoded #170

Open
aheusingfeld opened this issue Mar 29, 2015 · 3 comments
Open

Links/ href in Statuses not decoded #170

aheusingfeld opened this issue Mar 29, 2015 · 3 comments
Labels

Comments

@aheusingfeld
Copy link
Contributor

Links (the href part) in statuses don't seem to be url_decoded correctly. An example can be found in this status: https://intern.innoq.com/statuses/updates/3180 The contained ampersand is not decoded correctly.

@mvitz
Copy link
Contributor

mvitz commented Mar 30, 2015

Forgive me but I'm tired at the moment. What you expect is the following I guess:

http://foo.bar/baz?foo=bar&bar=baz should result in <a href="http://foo.bar/baz?foo=bar&bar=baz">http://foo.bar/baz?foo=bar&amp;bar=baz</a>

Is this correct?
Hiccups link-to function seems to escape the & as & in the href but not in the text by default...

@aheusingfeld
Copy link
Contributor Author

👍

@mvitz
Copy link
Contributor

mvitz commented Mar 30, 2015

Relates to: weavejester/hiccup#111

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants