Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

87 remove datasets - decrease package size #818

Merged
merged 7 commits into from
Dec 16, 2024
Merged

Conversation

m7pr
Copy link
Contributor

@m7pr m7pr commented Dec 13, 2024

In the spirit of package size reduction insightsengineering/nestdevs-tasks#87
I replaced all the calls for tmg datasets with their respective datasets from teal.data.
This way we no longer need to have datasets copies in tmg.

@m7pr m7pr added the core label Dec 13, 2024
@m7pr m7pr requested a review from llrs-roche December 13, 2024 10:26
Copy link
Contributor

github-actions bot commented Dec 13, 2024

badge

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  -------------------------------------------------
R/tm_a_pca.R                    884     884  0.00%    138-1155
R/tm_a_regression.R             772     772  0.00%    162-1036
R/tm_data_table.R               215     215  0.00%    110-380
R/tm_file_viewer.R              173     173  0.00%    47-255
R/tm_front_page.R               133     122  8.27%    73-231
R/tm_g_association.R            340     340  0.00%    143-556
R/tm_g_bivariate.R              685     421  38.54%   315-794, 835, 946, 963, 981, 992-1014
R/tm_g_distribution.R          1110    1110  0.00%    155-1411
R/tm_g_response.R               364     364  0.00%    161-601
R/tm_g_scatterplot.R            736     736  0.00%    244-1085
R/tm_g_scatterplotmatrix.R      296     277  6.42%    182-516, 577, 591
R/tm_missing_data.R            1111    1111  0.00%    122-1408
R/tm_outliers.R                1031    1031  0.00%    162-1342
R/tm_t_crosstable.R             261     261  0.00%    148-459
R/tm_variable_browser.R         830     825  0.60%    89-1081, 1119-1303
R/utils.R                       156     125  19.87%   81-266, 296-327, 348, 351, 356, 371-392, 403, 408
R/zzz.R                           2       2  0.00%    2-3
TOTAL                          9099    8769  3.63%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 2cc97e1

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

@llrs-roche llrs-roche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. LGTM

While checking the package locally I got an unrelated error from running a vignette:
"there is no package called ggpmics" there is a typo there and should be ggpmisc. Also on that vignette using-scatterplot.Rmd, the suggested dependency checks are not silent: requireNamespace("ggpmics") should be requireNamespace("ggpmics", quietly = TRUE) to avoid raising an error if they are not present. I'll open an issue to not forget about these.

@m7pr
Copy link
Contributor Author

m7pr commented Dec 13, 2024

Thanks @llrs-roche I pushed those 2 changes that you mentioned

@llrs-roche
Copy link
Contributor

Oh, I had opened a different issue to avoid doing too much here: #819

But if you do close that, be aware that the quietly = TRUE argument should be on all the requireNamespace calls, not only ggmics . Otherwise CRAN might come with a request to fix the package at any time.

Unrelated to this problem there seems to be an issue with join_keys<-, but I am not sure why this PR triggers that. Probably to fix it we might need to raise the dependency version required of on teal.data .

@m7pr
Copy link
Contributor Author

m7pr commented Dec 13, 2024

Got it! Will continue on Monday!

@m7pr m7pr enabled auto-merge (squash) December 16, 2024 08:13
Copy link
Contributor

github-actions bot commented Dec 16, 2024

Unit Tests Summary

  1 files   22 suites   13m 43s ⏱️
145 tests 108 ✅ 37 💤 0 ❌
477 runs  439 ✅ 38 💤 0 ❌

Results for commit 2cc97e1.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Dec 16, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
shinytest2-tm_g_bivariate 💔 $75.49$ $+1.16$ $0$ $0$ $0$ $0$
shinytest2-tm_outliers 💔 $112.94$ $+1.61$ $0$ $0$ $0$ $0$
shinytest2-tm_variable_browser 💔 $59.61$ $+2.00$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
examples 💀 $0.02$ $-0.02$ example_rADAE.Rd
examples 💀 $0.02$ $-0.02$ example_rADLB.Rd
examples 💀 $0.01$ $-0.01$ example_rADRS.Rd
examples 💀 $0.02$ $-0.02$ example_rADSL.Rd
examples 💀 $0.01$ $-0.01$ example_rADTTE.Rd

Results for commit 4db3c57

♻️ This comment has been updated with latest results.

@m7pr m7pr merged commit 5cf5f14 into main Dec 16, 2024
29 checks passed
@m7pr m7pr deleted the 87_remove_datasets@main branch December 16, 2024 09:01
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants