-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
87 remove datasets - decrease package size #818
Conversation
Code Coverage Summary
Diff against main
Results for commit: 2cc97e1 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. LGTM
While checking the package locally I got an unrelated error from running a vignette:
"there is no package called ggpmics" there is a typo there and should be ggpmisc. Also on that vignette using-scatterplot.Rmd, the suggested dependency checks are not silent: requireNamespace("ggpmics")
should be requireNamespace("ggpmics", quietly = TRUE)
to avoid raising an error if they are not present. I'll open an issue to not forget about these.
Thanks @llrs-roche I pushed those 2 changes that you mentioned |
Oh, I had opened a different issue to avoid doing too much here: #819 But if you do close that, be aware that the Unrelated to this problem there seems to be an issue with |
Got it! Will continue on Monday! |
Unit Tests Summary 1 files 22 suites 13m 43s ⏱️ Results for commit 2cc97e1. ♻️ This comment has been updated with latest results. |
Unit Test Performance Difference
Additional test case details
Results for commit 4db3c57 ♻️ This comment has been updated with latest results. |
In the spirit of package size reduction insightsengineering/nestdevs-tasks#87
I replaced all the calls for tmg datasets with their respective datasets from teal.data.
This way we no longer need to have datasets copies in tmg.